fix: hold delegate reference to keep it from being deallocated #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge activity
|
spikecurtis
force-pushed
the
spike/fix-sys-extn-delegate
branch
from
62199d8 to
33294fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem we were having before was being caused by the system extension delegate being deallocated before the request responses came back.
I didn't initially realize this, but the OSSystemRequest.delegate is a weak reference (you have to click down to the individual field view in the docs to learn this).
So, we keep a strong reference from the VPNService around while we are waiting for the extension to install.